Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: update the variable name related to Instance Plan Cache #56068

Merged
merged 6 commits into from
Sep 18, 2024

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Sep 13, 2024

What problem does this PR solve?

Issue Number: ref #54057

Problem Summary: planner: update the variable name related to Instance Plan Cache

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 13, 2024
Copy link

tiprow bot commented Sep 13, 2024

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.7695%. Comparing base (2bf89f8) to head (11d136f).
Report is 25 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56068         +/-   ##
=================================================
- Coverage   72.8845%   56.7695%   -16.1151%     
=================================================
  Files          1604       1762        +158     
  Lines        446805     638126     +191321     
=================================================
+ Hits         325652     362261      +36609     
- Misses       101095     251043     +149948     
- Partials      20058      24822       +4764     
Flag Coverage Δ
integration 39.3607% <66.6666%> (?)
unit 72.0728% <66.6666%> (+0.0840%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 61.8918% <ø> (+16.1880%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 13, 2024
Copy link

ti-chi-bot bot commented Sep 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-13 09:49:25.083496097 +0000 UTC m=+609034.823920037: ☑️ agreed by AilinKid.
  • 2024-09-13 10:48:33.634940671 +0000 UTC m=+612583.375364607: ☑️ agreed by time-and-fate.

Copy link

tiprow bot commented Sep 13, 2024

@qw4990: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 2aa95a1 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

@yudongusa yudongusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the changes.

@D3Hunter
Copy link
Contributor

/approve

Copy link

ti-chi-bot bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, D3Hunter, time-and-fate, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 18, 2024
@qw4990
Copy link
Contributor Author

qw4990 commented Sep 18, 2024

/merge

Copy link

ti-chi-bot bot commented Sep 18, 2024

@qw4990: We have migrated to builtin LGTM and approve plugins for reviewing.

👉 Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 3ae6470 into pingcap:master Sep 18, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants