Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: Datum.ToString() missed the case when datum is kindNull. #6647

Closed
wants to merge 3 commits into from
Closed

types: Datum.ToString() missed the case when datum is kindNull. #6647

wants to merge 3 commits into from

Conversation

winoros
Copy link
Member

@winoros winoros commented May 25, 2018

Just as title said.
PTAL @zz-jason @lamxTyler @XuHuaiyu

@shenli
Copy link
Member

shenli commented May 25, 2018

Please add a test case.

winkyao
winkyao reviewed May 25, 2018
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reset

@winkyao
Copy link
Contributor

winkyao commented May 25, 2018

@winoros Plz fix ci, and add some test cases

winkyao
winkyao suggested changes May 25, 2018
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reset LGTM

@coocood
Copy link
Member

coocood commented May 27, 2018

What if the string value is NULL?
Missing null type prevents us from forgetting to check null.

@winoros
Copy link
Member Author

winoros commented May 28, 2018 •
edited
Loading

@coocood show stats_buckets will use DatumsToString and may meet NULL values.

@coocood
Copy link
Member

coocood commented May 31, 2018

@winoros
We can check NULL in show stats_buckets

@coocood coocood closed this May 31, 2018
@winoros winoros deleted the datum-to-string branch June 7, 2018 02:21
@winoros winoros mentioned this pull request Sep 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winkyao winkyao winkyao requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@winoros @shenli @winkyao @coocood @ngaut