Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor:update vendor for tracing #7067

Merged
merged 3 commits into from
Jul 17, 2018

Conversation

zhexuany
Copy link
Contributor

What have you changed? (mandatory)

only update vendor which is preparation for tracing.

What is the type of the changes? (mandatory)

  • Improvement (non-breaking change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

No need for test

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

Does this PR affect tidb-ansible update? (mandatory)

Nope

Does this PR need to be added to the release notes? (mandatory)

Nope

Refer to a related PR or issue link (optional)

#7063
#7016

@zz-jason
Copy link
Member

LGTM

@zz-jason
Copy link
Member

@zhexuany please add some labels for this PR.

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 17, 2018
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala
Copy link
Contributor

/run-all-tests

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 17, 2018
@zhexuany zhexuany added the type/enhancement The issue or PR belongs to an enhancement. label Jul 17, 2018
@coocood coocood merged commit 329c12c into pingcap:master Jul 17, 2018
@zhexuany zhexuany deleted the update_vendor_for_tracing branch October 22, 2018 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants