Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distsql: let analyze use RC level and low priority #7496

Merged
merged 3 commits into from
Aug 27, 2018

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Aug 27, 2018

What problem does this PR solve?

Analyze request should use RC isolation level and low priority.

What is changed and how it works?

Set the isolation level and priority when building analyze request.

Check List

Tests

  • Unit test

Code changes

  • Has unexported function/method change

Side effects

  • None

Related changes

  • Need to cherry-pick to the release branch

PTAL @coocood @zz-jason @winoros

@alivxxx alivxxx added component/statistics type/enhancement The issue or PR belongs to an enhancement. labels Aug 27, 2018
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx
Copy link
Contributor Author

alivxxx commented Aug 27, 2018

/run-all-tests

@alivxxx alivxxx added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 27, 2018
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx
Copy link
Contributor Author

alivxxx commented Aug 27, 2018

Using a table of 10 million rows, running sysbench oltp test when analyzing:

sysbench threads SI RC
8 55s 40s
16 1min7s 48s
32 resolve lock timeout 1min2s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/statistics status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants