Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: fix bug which Float type is not effective in AddDate & SubDate… #8009

Merged
merged 3 commits into from
Oct 23, 2018
Merged

types: fix bug which Float type is not effective in AddDate & SubDate… #8009

merged 3 commits into from
Oct 23, 2018

Conversation

lzmhhh123
Copy link
Contributor

What problem does this PR solve?

cherry-pick #7840

@zz-jason
Copy link
Member

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 23, 2018
@zz-jason
Copy link
Member

/run-all-tests tikv=release-2.1 pd=release-2.1

@zz-jason
Copy link
Member

@XuHuaiyu @lamxTyler PTAL

XuHuaiyu
XuHuaiyu approved these changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 23, 2018
@zz-jason zz-jason merged commit 6cb942b into pingcap:release-2.1 Oct 23, 2018
@lzmhhh123 lzmhhh123 deleted the release-2.1f branch November 13, 2018 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lzmhhh123 @zz-jason @XuHuaiyu @ngaut