plan: disable plan cache for query containing SubqueryExpr
#8064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
LGTM |
eurekaka
added
status/LGT2
This was referenced Nov 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #8062
What is changed and how it works?
The reason of the wrong result is: during first
executein session 1, a plan would be built and cached; during the expression rewriting of the plan building step, un-correlated subquery is detected and evaluated in optimizer, so the query is simplified toselect * from t where a = null, thus theParamMarkerExpris lost in the plan, so we get empty result in the secondexecute.Check the AST and mark it uncacheable if it contains
SubqueryExpr.Check List
Tests
Code changes
Side effects
N/A
Related changes