planner,executor,parser: support the plan cache for prepared insert/delete/update statements

[dbjoa]

What problem does this PR solve?

Support the plan cache for the prepared insert/delete/update statements

What is changed and how it works?

• Extend rebuildRange() to support the insert/update/delete plans
• Allow prepared insert/update/delete statements to be cacheable

Check List

Tests

• Unit test

Code changes

• Has exported function/method change

Side effects

• No

Related changes

• Need to be included in the release note

[sre-bot]

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

[dbjoa]

/run-all-tests

[shenli]

@dbjoa Thanks!

[dbjoa]

/run-common-test

[eurekaka]

Could you please give an example where n.Table is nil in INSERT?

[dbjoa]

I don't know a real example. The code is to pass the test case below .
https://github.com/pingcap/tidb/blob/6fbb42d22bdfdbe4822174c44430b64f7946b73f/planner/core/cacheable_checker_test.go#L41-L42

[eurekaka]

I see, then this code change is unreasonable IMHO. By the way, I learned that since we have moved parser to a separate repository, we need to file a PR in https://github.com/pingcap/parser if we want to make changes, and then make update in tidb repo.

[eurekaka]

The failed common-test can be simplified to this test case:

import java.sql.*;

class TiDBTestConnector {
	public static void main(String args[]){
		try{
				ResultSet rs;
				Class.forName("com.mysql.jdbc.Driver");
				Connection con=DriverManager.getConnection("jdbc:mysql://127.0.0.1:4000/test?useServerPrepStmts=true","root","");
				//createTable("testExecuteLargeBatch", "(id BIGINT AUTO_INCREMENT PRIMARY KEY, n INT)");
				PreparedStatement stmt = con.prepareStatement("INSERT INTO testExecuteLargeBatch (n) VALUES (?)", Statement.RETURN_GENERATED_KEYS);
				stmt.setInt(1, 1);
				stmt.addBatch();
				stmt.setInt(1, 2);
				stmt.addBatch();
				stmt.setInt(1, 3);
				stmt.addBatch();
				stmt.setInt(1, 4);
				stmt.addBatch();
				stmt.addBatch("INSERT INTO testExecuteLargeBatch (n) VALUES (5), (6), (7)");
				stmt.setString(1, "eight");
				stmt.addBatch();
				stmt.addBatch("INSERT INTO testExecuteLargeBatch (n) VALUES (9), (10)");
				try {
					stmt.executeLargeBatch();
					System.out.println("error, should raise exception");
				} catch (BatchUpdateException e) {
					String err = "Incorrect int value: 'eight' for column 'n' at row 1";
					if (!err.equals(e.getMessage())) {
						System.out.println("wrong error message: " + e.getMessage());
					}
				}
				System.out.println("finished");
				con.close();
		}catch(Exception e) { System.out.println(e); }
	}
}

when plan cache is enabled, the error message returned is wrong: Incorrect int value: '4' for column 'n' at row 1, you can use this for diagnosing.

[dbjoa]

@eurekaka, Thank you for the test case. I'll come back after fixing the failure.

[dbjoa]

@eurekaka, The updated PR should fix the test failure.

[dbjoa]

/run-all-tests

[eurekaka]

LGTM, except for the parser part mentioned. @zz-jason @winoros @lamxTyler PTAL.

[dbjoa]

@eurekaka, I've made the parser PR #5.

[zimulala]

Why here use the level of “Error”？

[dbjoa]

Thank you for the comment. The PR should remove the debugging code. I'll delete the line from the updated PR.

[zimulala]

Could we remove this blank line?

[dbjoa]

Thank you for the comment. I'll delete the line from the updated PR.

[dbjoa]

/run-all-tests

[dbjoa]

@eurekaka, @zimulala PTAL

[eurekaka]

LGTM

[XuHuaiyu]

Really great work! Rest LGTM

[XuHuaiyu]

LGTM