planner/core, expression: don't pushdown filters contains set or get var #8412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zz-jason
added a commit
to zz-jason/tidb
that referenced
this pull request
Nov 22, 2018
zz-jason
added
type/enhancement
|
/run-all-tests |
eurekaka
reviewed
Nov 23, 2018
|
@eurekaka comments addressed, PTAL |
eurekaka
added
status/LGT2
|
/run-all-tests |
|
/run-common-test tidb-test=pr/667 |
zz-jason
added a commit
to zz-jason/tidb
that referenced
this pull request
Nov 26, 2018
zz-jason
added a commit
that referenced
this pull request
Nov 26, 2018
zz-jason
added a commit
to zz-jason/tidb
that referenced
this pull request
Nov 26, 2018
zz-jason
added a commit
that referenced
this pull request
Nov 29, 2018
13 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
For filters contain
SetVarorGetVar, donot push it down. Make it possible to use user variables to simulate the window function.Check List
Tests
Code changes
Related changes
This change is