Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: change default charset and collation from 'utf8 utf8_bin' to 'utf8mb4 utf8mb4_bin' (#7965) #8590

Merged
merged 10 commits into from
Dec 6, 2018
Merged

*: change default charset and collation from 'utf8 utf8_bin' to 'utf8mb4 utf8mb4_bin' (#7965) #8590

merged 10 commits into from
Dec 6, 2018

Conversation

winkyao
Copy link
Contributor

@winkyao winkyao commented Dec 6, 2018 •
edited
Loading

What problem does this PR solve?

cherry-pick from #7965

This change is Reviewable

Please merge pingcap/parser#68 first.

@winkyao
Copy link
Contributor Author

winkyao commented Dec 6, 2018

@crazycs520 @XuHuaiyu @tiancaiamao PTAL

zimulala
zimulala reviewed Dec 6, 2018
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT1 Indicates that a PR has LGTM 1. component/DDL-need-LGT3 labels Dec 6, 2018
@winkyao winkyao mentioned this pull request Dec 6, 2018
Merged
ciscoxll
ciscoxll reviewed Dec 6, 2018
View reviewed changes
Copy link
Contributor

@ciscoxll ciscoxll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zz-jason
zz-jason previously approved these changes Dec 6, 2018
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 6, 2018
@zz-jason
Copy link
Member

zz-jason commented Dec 6, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@winkyao
Copy link
Contributor Author

winkyao commented Dec 6, 2018

ci will be fixed after pingcap/parser#68 merged and https://github.com/pingcap/tidb-test/pull/677 merged.

@winkyao
Copy link
Contributor Author

winkyao commented Dec 6, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1 -tidb-test=pr/677

@winkyao
Copy link
Contributor Author

winkyao commented Dec 6, 2018

/run-common-test -tidb-test=pr/677 tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@winkyao
Copy link
Contributor Author

winkyao commented Dec 6, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@winkyao
Copy link
Contributor Author

winkyao commented Dec 6, 2018

/run-common-test -tidb-test=pr/677 tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

4 similar comments
@winkyao
Copy link
Contributor Author

winkyao commented Dec 6, 2018

/run-common-test -tidb-test=pr/677 tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@winkyao
Copy link
Contributor Author

winkyao commented Dec 6, 2018

/run-common-test -tidb-test=pr/677 tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@winkyao
Copy link
Contributor Author

winkyao commented Dec 6, 2018

/run-common-test -tidb-test=pr/677 tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@winkyao
Copy link
Contributor Author

winkyao commented Dec 6, 2018

/run-common-test -tidb-test=pr/677 tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@winkyao
Copy link
Contributor Author

winkyao commented Dec 6, 2018

/run-common-test -tidb-test=pr/678 tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@winkyao
Copy link
Contributor Author

winkyao commented Dec 6, 2018

/run-all-tests -tidb-test=pr/678 tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

XuHuaiyu
XuHuaiyu approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao winkyao merged commit d9d153e into pingcap:release-2.1 Dec 6, 2018
@winkyao winkyao deleted the cherry-pick-2.1-charset branch December 6, 2018 11:11
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@ciscoxll ciscoxll ciscoxll left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@zz-jason zz-jason zz-jason left review comments

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@winkyao @zz-jason @zimulala @XuHuaiyu @ciscoxll @you06