Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: ignore unknown hint and return warning instead of return error(#8685) #8766

Merged
merged 5 commits into from
Dec 22, 2018
Merged

*: ignore unknown hint and return warning instead of return error(#8685) #8766

merged 5 commits into from
Dec 22, 2018

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Dec 21, 2018

cherry-pick #8685 to 2.1

using parser version pingcap/parser#101


This change is Reviewable

@lysu
Copy link
Contributor Author

lysu commented Dec 21, 2018

/run-all-tests tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu
Copy link
Contributor Author

lysu commented Dec 21, 2018

/run-all-tests tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1

@lysu
Copy link
Contributor Author

lysu commented Dec 21, 2018

/run-unit-test tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 22, 2018
@zz-jason zz-jason merged commit 4926253 into pingcap:release-2.1 Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/parser status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants