server: compatible to old handshake protocol #8812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackysp
reviewed
Dec 25, 2018
imtbkcat
force-pushed
the
handshake320
branch
from
7c09c6c
to
eae108c
Compare
|
/run-all-tests |
|
/run-unit-test |
imtbkcat
force-pushed
the
handshake320
branch
from
3ffb782
to
43db3f5
Compare
|
/run-all-tests |
lysu
reviewed
Dec 26, 2018
server/conn.go
Outdated
| var resp handshakeResponse41 | ||
|
|
||
| pos, err := parseHandshakeResponseHeader(&resp, data) | ||
| if err != nil { | ||
| return errors.Trace(err) | ||
| if err == mysql.ErrMalformPacket { |
There was a problem hiding this comment.
Protocol::HandshakeResponse41:
Handshake Response Packet sent by 4.1+ clients supporting CLIENT_PROTOCOL_41 capability, if the server announced it in its Initial Handshake Packet. Otherwise (talking to an old server) the Protocol::HandshakeResponse320 packet must be used.
https://dev.mysql.com/doc/internals/en/connection-phase-packets.html
@imtbkcat can we direct use CLIENT_PROTOCOL_41 capability to decide use 41 or 32, because our Initial Handshake Packet always contain ClientProtocol41?
parse handshake twice has risk
jackysp
reviewed
Dec 26, 2018
server/conn.go
Outdated
| // parseHandshakeResponseHeader parses the common header of SSLRequest and HandshakeResponse41. | ||
| func parseHandshakeResponseHeader(packet *handshakeResponse41, data []byte) (parsedBytes int, err error) { | ||
| // Ensure there are enough data to read: | ||
| // http://dev.mysql.com/doc/internals/en/connection-phase-packets.html#packet-Protocol::SSLRequest | ||
| if len(data) < 4+4+1+23 { | ||
| log.Errorf("Got malformed handshake response, packet data: %v", data) |
There was a problem hiding this comment.
It's better to add it back if we don't parse protocol 41 first.
|
/run-all-tests |
imtbkcat
pushed a commit
to imtbkcat/tidb
that referenced
this pull request
Dec 27, 2018
imtbkcat
pushed a commit
to imtbkcat/tidb
that referenced
this pull request
Dec 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When using HAProxy connect to TiDB server,
option mysql-check user rootwill cause handshake fail error because TiDB do not support Protocol::HandshakeResponse320What is changed and how it works?
Parser
Protocol::HandshakeResponse320toProtocol::HandshakeResponse41, which is supported by TiDB.Check List
Tests
Code changes
Side effects
Related changes
This change is