planner/core: make join reorder by dp work #8816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The impact on TPCH has not been validated. |
|
/run-all-tests |
winoros
force-pushed
the
join-reorder-dp
branch
from
fe5ad2a
to
841945e
Compare
winoros
force-pushed
the
join-reorder-dp
branch
from
841945e
to
868a44d
Compare
|
/run-all-tests |
|
/run-all-tests |
winoros
changed the title
alivxxx
reviewed
Dec 29, 2018
winoros
force-pushed
the
join-reorder-dp
branch
from
cba29b9
to
dd7cd1a
Compare
alivxxx
reviewed
Jan 4, 2019
sessionctx/variable/session.go
Outdated
| @@ -690,6 +695,8 @@ func (s *SessionVars) SetSystemVar(name string, val string) error { | |||
| s.EnableRadixJoin = TiDBOptOn(val) | |||
| case TiDBEnableWindowFunction: | |||
| s.EnableWindowFunction = TiDBOptOn(val) | |||
| case TiDBOptJoinOrderAlgoThreshold: | |||
| s.TiDBOptJoinOrderAlgoThreshold = tidbOptPositiveInt32(val, DefTiDBOptJoinOrderAlgoThreshold) | |||
There was a problem hiding this comment.
Should we also limit its upper bound?
There was a problem hiding this comment.
I think the set it too large can be treated as that we want every join order calculated by dp.
Though it not reasonable in a real environment, i think it's reasonable in logic...
There was a problem hiding this comment.
If it is larger than 64, will the DP algorithm panic?
eurekaka
reviewed
Jan 4, 2019
eurekaka
reviewed
Jan 7, 2019
|
@winoros Any updates? |
|
Disable by default. |
zz-jason
reviewed
Mar 4, 2019
alivxxx
reviewed
Mar 6, 2019
zz-jason
reviewed
Mar 7, 2019
winoros
requested review from
eurekaka and
alivxxx
and removed request for
eurekaka
zz-jason
approved these changes
Apr 24, 2019
zz-jason
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Make the algo that use dp to do the join reorder integrated with the current planner.
What is changed and how it works?
The original algo only considers equal conditions. This time we add support for
OhterConds.And when the join node is no greater than 10, we'll choose it. Otherwise, we'll use the greedy one.
Check List
Tests
Code changes
Side effects
Related changes
This change is