Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: support sql_mode ALLOW_INVALID_DATES (#9027) #9110

Merged
merged 3 commits into from
Jan 20, 2019
Merged

types: support sql_mode ALLOW_INVALID_DATES (#9027) #9110

merged 3 commits into from
Jan 20, 2019

Conversation

bobotu
Copy link
Contributor

@bobotu bobotu commented Jan 18, 2019

Cherry pick #9027 to release 2.1, needs pingcap/parser#185

@bobotu
Copy link
Contributor Author

bobotu commented Jan 18, 2019

PTAL @jackysp

jackysp
jackysp reviewed Jan 18, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp requested a review from gregwebs January 18, 2019 03:31
@jackysp
Copy link
Member

jackysp commented Jan 18, 2019

PTAL @gregwebs

@jackysp jackysp requested a review from lysu January 18, 2019 03:33
@gregwebs
Copy link
Contributor

Thank you! If possible, the replace directive should point to this repository (but a different git version).

@lysu
Copy link
Contributor

lysu commented Jan 18, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

lysu
lysu previously approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ngaut
ngaut approved these changes Jan 20, 2019
View reviewed changes
Copy link
Member

@ngaut ngaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngaut ngaut merged commit 788fbf2 into pingcap:release-2.1 Jan 20, 2019
@bobotu bobotu deleted the cp-allow-invalid-dates branch August 10, 2020 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@ngaut ngaut ngaut approved these changes

@lysu lysu lysu left review comments

@gregwebs gregwebs Awaiting requested review from gregwebs

Assignees
No one assigned
Labels
type/compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bobotu @jackysp @gregwebs @lysu @ngaut