planner/core: implement skyline pruning #9337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alivxxx
added
type/enhancement
Codecov Report
@@ Coverage Diff @@
## master #9337 +/- ##
==========================================
+ Coverage 67.13% 67.16% +0.02%
==========================================
Files 372 372
Lines 77768 77839 +71
==========================================
+ Hits 52211 52277 +66
- Misses 20887 20891 +4
- Partials 4670 4671 +1
Continue to review full report at Codecov.
|
winoros
reviewed
Feb 18, 2019
| @@ -567,11 +567,6 @@ func loadAllTests() ([]string, error) { | |||
| if strings.HasSuffix(name, ".test") { | |||
| name = strings.TrimSuffix(name, ".test") | |||
|
|
|||
| // if we use record and the result file exists, skip generating | |||
There was a problem hiding this comment.
Make ./run-all-tests -r all work.
There was a problem hiding this comment.
Nice, maybe the logic in tidb-test repo should also be changed?
qw4990
reviewed
Feb 18, 2019
XuHuaiyu
reviewed
Feb 18, 2019
XuHuaiyu
reviewed
Feb 18, 2019
dcalvin
reviewed
Feb 18, 2019
zz-jason
reviewed
Feb 18, 2019
|
/run-all-tests |
XuHuaiyu
reviewed
Feb 18, 2019
alivxxx
added
status/LGT2
alivxxx
added a commit
to alivxxx/tidb
that referenced
this pull request
Feb 19, 2019
jackysp
pushed a commit
that referenced
this pull request
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #8593
What is changed and how it works?
Implement the skyline pruning according to the proposal.
Check List
Tests
Code changes
Side effects
Related changes