Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plan/executor: make semi joins null and empty aware (#9051) #9449

Merged
merged 3 commits into from
Feb 25, 2019
Merged

plan/executor: make semi joins null and empty aware (#9051) #9449

merged 3 commits into from
Feb 25, 2019

Conversation

eurekaka
Copy link
Contributor

cherry-pick #9051

@eurekaka eurekaka added type/bugfix This PR fixes a bug. sig/planner SIG: Planner sig/execution SIG execution type/2.1 cherry-pick labels Feb 25, 2019
zz-jason
zz-jason reviewed Feb 25, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 25, 2019
winoros
winoros reviewed Feb 25, 2019
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eurekaka
Copy link
Contributor Author

/run-all-tests tidb-test=pr/745 tikv=release-2.1 pd=release-2.1

@eurekaka
Copy link
Contributor Author

/run-all-tests tidb-test=pr/745 tikv=release-2.1 pd=release-2.1

@zz-jason zz-jason merged commit e58cae4 into pingcap:release-2.1 Feb 25, 2019
@eurekaka eurekaka deleted the null_semi_join_21 branch February 25, 2019 11:10
@mxlxm mxlxm mentioned this pull request Apr 22, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@winoros winoros winoros approved these changes

Assignees
No one assigned
Labels
sig/execution SIG execution sig/planner SIG: Planner status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eurekaka @zz-jason @winoros