Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: support window function rank and dense_rank #9500

Merged
merged 2 commits into from
Feb 28, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Feb 28, 2019

What problem does this PR solve?

Support window function rank and dense_rank.
See https://dev.mysql.com/doc/refman/8.0/en/window-function-descriptions.html#function_rank and https://dev.mysql.com/doc/refman/8.0/en/window-function-descriptions.html#function_dense-rank

For #9499

What is changed and how it works?

Implement the function using the agg function interface.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • None

@alivxxx alivxxx added type/enhancement The issue or PR belongs to an enhancement. sig/execution SIG execution labels Feb 28, 2019
@alivxxx alivxxx mentioned this pull request Feb 28, 2019
11 tasks
@codecov-io
Copy link

Codecov Report

Merging #9500 into master will decrease coverage by 0.05%.
The diff coverage is 6.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9500      +/-   ##
==========================================
- Coverage   67.42%   67.37%   -0.06%     
==========================================
  Files         373      374       +1     
  Lines       78568    78620      +52     
==========================================
- Hits        52976    52969       -7     
- Misses      20837    20892      +55     
- Partials     4755     4759       +4
Impacted Files Coverage Δ
executor/aggfuncs/builder.go 32.12% <0%> (-2.51%) ⬇️
executor/aggfuncs/func_rank.go 0% <0%> (ø)
expression/aggregation/base_func.go 48.2% <0%> (ø) ⬆️
executor/builder.go 83.82% <100%> (+0.03%) ⬆️
ddl/delete_range.go 75.13% <0%> (-5.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddbf60f...85b9297. Read the comment docs.

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

/run-all-tests

@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 28, 2019
@zz-jason
Copy link
Member

/run-integration-compatibility-test

@zz-jason zz-jason merged commit 9259785 into pingcap:master Feb 28, 2019
@alivxxx alivxxx deleted the rank branch February 28, 2019 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants