Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: support window function cume_dist #9619

Merged
merged 6 commits into from
Mar 11, 2019
Merged

executor: support window function cume_dist #9619

merged 6 commits into from
Mar 11, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Mar 8, 2019

What problem does this PR solve?

Support window function cume_dist. Refer https://dev.mysql.com/doc/refman/8.0/en/window-function-descriptions.html#function_cume-dist

For #9499

What is changed and how it works?

Implement the cume_dist under the aggfunc interface.

Check List

Tests

  • Integration test

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • None

@alivxxx alivxxx added type/enhancement The issue or PR belongs to an enhancement. sig/execution SIG execution labels Mar 8, 2019
@alivxxx alivxxx mentioned this pull request Mar 8, 2019
Closed
11 tasks
@codecov
Copy link

codecov bot commented Mar 8, 2019 •
edited
Loading

Codecov Report

Merging #9619 into master will decrease coverage by 0.0439%.
The diff coverage is 0%.

@@               Coverage Diff               @@
##             master      #9619       +/-   ##
===============================================
- Coverage   67.4239%   67.3799%   -0.044%     
===============================================
  Files           375        376        +1     
  Lines         79144      79160       +16     
===============================================
- Hits          53362      53338       -24     
- Misses        21006      21052       +46     
+ Partials       4776       4770        -6

zhouqiang-cl and others added 2 commits March 9, 2019 17:38
zz-jason
zz-jason reviewed Mar 11, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 11, 2019
@alivxxx
Copy link
Contributor Author

alivxxx commented Mar 11, 2019

/run-all-tests

qw4990
qw4990 approved these changes Mar 11, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 11, 2019
@alivxxx alivxxx merged commit f0aca29 into pingcap:master Mar 11, 2019
@alivxxx alivxxx deleted the cume_dist branch March 11, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@qw4990 qw4990 qw4990 approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alivxxx @zz-jason @qw4990 @xiekeyi98 @zhouqiang-cl