executor: add window function NTILE #9682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alivxxx
reviewed
Mar 13, 2019
Codecov Report
@@ Coverage Diff @@
## master #9682 +/- ##
================================================
- Coverage 67.2243% 67.1998% -0.0246%
================================================
Files 380 381 +1
Lines 79788 79835 +47
================================================
+ Hits 53637 53649 +12
- Misses 21361 21404 +43
+ Partials 4790 4782 -8 |
alivxxx
reviewed
Mar 13, 2019
executor/aggfuncs/func_ntile.go
Outdated
|
|
||
| type partialResult4Ntile struct { | ||
| curIdx uint64 | ||
| divisor uint64 |
There was a problem hiding this comment.
Is it needed? Can we just use the n in ntile?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Implement window function NTILE. It divides the rows into n groups, and returns the group number a row belongs to.
Part of #9499
What is changed and how it works?
Implement its execution logic
Check List
Tests
Related changes