*: fix the read-only check for the prepare/execute statement #9723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
ngaut
reviewed
Mar 14, 2019
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #9723 +/- ##
================================================
+ Coverage 77.4754% 77.5712% +0.0957%
================================================
Files 403 404 +1
Lines 81782 81761 -21
================================================
+ Hits 63361 63423 +62
+ Misses 13705 13649 -56
+ Partials 4716 4689 -27 |
|
/run-all-tests |
|
/run-unit-test |
|
/run-all-tests |
jackysp
added a commit
to jackysp/tidb
that referenced
this pull request
Apr 2, 2019
jackysp
added a commit
to jackysp/tidb
that referenced
this pull request
Apr 4, 2019
jackysp
added a commit
that referenced
this pull request
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
For binary protocol,
prepare select * from t where i = 1thenexecute stmtwill mark the statement as not read-only.What is changed and how it works?
Get the real prepare statement when checking read-only.
Check List
Tests
Code changes
Related changes