Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix last_day function #9750

Merged
merged 3 commits into from
Mar 23, 2019
Merged

expression: fix last_day function #9750

merged 3 commits into from
Mar 23, 2019

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Mar 15, 2019 •
edited by zz-jason
Loading

What problem does this PR solve?

fix #9731

What is changed and how it works?

Fix last_day function

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@wjhuang2016 wjhuang2016 changed the title Fix last_day function expression: fix last_day function Mar 15, 2019
alivxxx
alivxxx reviewed Mar 15, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added type/2.1 cherry-pick status/LGT1 Indicates that a PR has LGTM 1. labels Mar 15, 2019
zimulala
zimulala reviewed Mar 18, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala
Copy link
Contributor

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 18, 2019
@qw4990 qw4990 mentioned this pull request Mar 18, 2019
Closed
30 tasks
@zimulala
Copy link
Contributor

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@zz-jason zz-jason added status/all tests passed component/expression contribution This PR is from a community contributor. labels Mar 23, 2019
@zz-jason zz-jason merged commit 6f0129f into pingcap:release-2.1 Mar 23, 2019
@wjhuang2016 wjhuang2016 deleted the fix_last_day_for_2.1 branch March 23, 2019 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alivxxx alivxxx alivxxx left review comments

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wjhuang2016 @zimulala @alivxxx @zz-jason