Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: fix time_format is not compatible with MySQL. #9841

Merged
merged 3 commits into from
Mar 25, 2019
Merged

types: fix time_format is not compatible with MySQL. #9841

merged 3 commits into from
Mar 25, 2019

Conversation

lzmhhh123
Copy link
Contributor

What problem does this PR solve?

fix #9774

What is changed and how it works?

Just do time.hour modular for some formats.

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

@codecov
Copy link

codecov bot commented Mar 21, 2019 •
edited
Loading

Codecov Report

Merging #9841 into master will increase coverage by 0.0004%.
The diff coverage is 66.6666%.

@@               Coverage Diff                @@
##             master      #9841        +/-   ##
================================================
+ Coverage   67.3554%   67.3558%   +0.0004%     
================================================
  Files           383        383                
  Lines         80436      80437         +1     
================================================
+ Hits          54178      54179         +1     
- Misses        21414      21415         +1     
+ Partials       4844       4843         -1

@qw4990 qw4990 mentioned this pull request Mar 23, 2019
Closed
30 tasks
crazycs520
crazycs520 reviewed Mar 25, 2019
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alivxxx
alivxxx approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 25, 2019
@alivxxx
Copy link
Contributor

alivxxx commented Mar 25, 2019

/run-all-tests

@zhouqiang-cl
Copy link
Contributor

/rebuild

@zhouqiang-cl
Copy link
Contributor

/run-all-tests

@zz-jason
Copy link
Member

/run-unit-test

@zz-jason zz-jason merged commit 99defc0 into pingcap:master Mar 25, 2019
qw4990 pushed a commit to qw4990/tidb that referenced this pull request May 15, 2019
@lzmhhh123 @qw4990
types: fix time_format is not compatible with MySQL (pingcap#9841)
c6edfb2
@qw4990 qw4990 mentioned this pull request May 15, 2019
Merged
zz-jason pushed a commit that referenced this pull request May 15, 2019
@qw4990 @zz-jason
types: fix time_format is not compatible with MySQL (#9841) (#10474)
205418a
@lzmhhh123 lzmhhh123 deleted the dev/fix9774 branch July 24, 2019 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 left review comments

@alivxxx alivxxx alivxxx approved these changes

Assignees
No one assigned
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TIME_FORMAT is not compatible with MySQL
5 participants
@lzmhhh123 @alivxxx @zhouqiang-cl @zz-jason @crazycs520