planner, executor: merge window functions with same specification name #9866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alivxxx
added
type/enhancement
Codecov Report
@@ Coverage Diff @@
## master #9866 +/- ##
===============================================
+ Coverage 77.346% 77.3526% +0.0065%
===============================================
Files 413 413
Lines 87380 87498 +118
===============================================
+ Hits 67585 67682 +97
- Misses 14603 14615 +12
- Partials 5192 5201 +9 |
winoros
reviewed
Mar 25, 2019
winoros
reviewed
Mar 25, 2019
zz-jason
added
the
priority/release-blocker
|
PTLA @winoros |
winoros
reviewed
May 23, 2019
|
/run-all-tests |
|
/run-unit-test |
alivxxx
added
status/LGT2
db-storage
pushed a commit
to db-storage/tidb
that referenced
this pull request
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Previously, we could only process one window function in one window executor. This PR merges the execution of different window functions according to their window specification name.
What is changed and how it works?
In the planner stage, it first extracts the window functions from field list and order by clause. After that, it groups and builds the window functions according to specification name. In the executor, it also adjusts the executor so it can handle multiple window functions.
Check List
Tests
Code changes
Side effects
Related changes