Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plan: support subquery in Do statement (#8343) #9877

Merged
merged 5 commits into from
Mar 25, 2019
Merged

plan: support subquery in Do statement (#8343) #9877

merged 5 commits into from
Mar 25, 2019

Conversation

eurekaka
Copy link
Contributor

cherry-pick #8343

@eurekaka eurekaka added type/bugfix This PR fixes a bug. sig/planner SIG: Planner type/2.1 cherry-pick labels Mar 25, 2019
@zz-jason
Copy link
Member

LGTM

@zz-jason
Copy link
Member

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason
Copy link
Member

/rebuild

@zz-jason
Copy link
Member

zz-jason commented Mar 25, 2019 •
edited
Loading 

# github.com/pingcap/tidb/planner/core_test [github.com/pingcap/tidb/planner/core.test]
planner/core/physical_plan_test.go:1332:13: undefined: planner

UT failed

@eurekaka
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@eurekaka eurekaka added type/enhancement The issue or PR belongs to an enhancement. and removed type/bugfix This PR fixes a bug. labels Mar 25, 2019
@zz-jason zz-jason requested a review from winoros March 25, 2019 05:51
@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 25, 2019
XuHuaiyu
XuHuaiyu approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 705341b into pingcap:release-2.1 Mar 25, 2019
@eurekaka eurekaka deleted the pick_do_2.1 branch December 18, 2019 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eurekaka @zz-jason @XuHuaiyu