Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner/core: raise warning for unmatched join hint (#9914) #9970

Merged
merged 3 commits into from
Apr 1, 2019
Merged

planner/core: raise warning for unmatched join hint (#9914) #9970

merged 3 commits into from
Apr 1, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Apr 1, 2019

Cherry-pick #9914

zz-jason
zz-jason reviewed Apr 1, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 1, 2019
@alivxxx
Copy link
Contributor Author

alivxxx commented Apr 1, 2019 •
edited
Loading

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

1 similar comment
@alivxxx
Copy link
Contributor Author

alivxxx commented Apr 1, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

eurekaka
eurekaka approved these changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 1, 2019
@zz-jason zz-jason merged commit fe7aefa into pingcap:release-2.1 Apr 1, 2019
@alivxxx alivxxx deleted the join-hint branch April 28, 2019 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@eurekaka eurekaka eurekaka approved these changes

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alivxxx @zz-jason @eurekaka