Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load progress in query-status sometimes become smaller #3252

Closed
GMHDBJD opened this issue Nov 3, 2021 · 3 comments · Fixed by #3459 or #4093
Closed

load progress in query-status sometimes become smaller #3252

GMHDBJD opened this issue Nov 3, 2021 · 3 comments · Fixed by #3459 or #4093
Assignees
Labels
area/dm Issues or PRs related to DM. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@GMHDBJD
Copy link
Contributor

GMHDBJD commented Nov 3, 2021

What did you do?

query-status when in load stage

What did you expect to see?

load progress become larger

What did you see instead?

sometimes become smaller

tiup dmctl:v2.0.7 --master-addr=172.16.6.1:8161 query-status test -s mysql-replica-01
Starting component `dmctl`: /home/gmhdbjd/.tiup/components/dmctl/v2.0.7/dmctl/dmctl --master-addr=172.16.6.1:8161 query-status test -s mysql-replica-01
{
    "result": true,
    "msg": "",
    "sources": [
        {
            "result": true,
            "msg": "",
            "sourceStatus": {
                "source": "mysql-replica-01",
                "worker": "dm-172.16.6.7-8363",
                "result": null,
                "relayStatus": null
            },
            "subTaskStatus": [
                {
                    "name": "test",
                    "stage": "Running",
                    "unit": "Load",
                    "result": null,
                    "unresolvedDDLLockID": "",
                    "load": {
                        "finishedBytes": "65011251",
                        "totalBytes": "3854328608",
                        "progress": "1.69 %",
                        "metaBinlog": "(mysql-bin.000005, 918368254)",
                        "metaBinlogGTID": "1e62060e-3c65-11ec-a30b-0242ac110002:1-5633"
                    }
                }
            ]
        }
    ]
}
tiup dmctl:v2.0.7 --master-addr=172.16.6.1:8161 query-status test -s mysql-replica-01
Starting component `dmctl`: /home/gmhdbjd/.tiup/components/dmctl/v2.0.7/dmctl/dmctl --master-addr=172.16.6.1:8161 query-status test -s mysql-replica-01
{
    "result": true,
    "msg": "",
    "sources": [
        {
            "result": true,
            "msg": "",
            "sourceStatus": {
                "source": "mysql-replica-01",
                "worker": "dm-172.16.6.7-8363",
                "result": null,
                "relayStatus": null
            },
            "subTaskStatus": [
                {
                    "name": "test",
                    "stage": "Running",
                    "unit": "Load",
                    "result": null,
                    "unresolvedDDLLockID": "",
                    "load": {
                        "finishedBytes": "67108866",
                        "totalBytes": "3854328608",
                        "progress": "1.74 %",
                        "metaBinlog": "(mysql-bin.000005, 918368254)",
                        "metaBinlogGTID": "1e62060e-3c65-11ec-a30b-0242ac110002:1-5633"
                    }
                }
            ]
        }
    ]
}
tiup dmctl:v2.0.7 --master-addr=172.16.6.1:8161 query-status test -s mysql-replica-01
Starting component `dmctl`: /home/gmhdbjd/.tiup/components/dmctl/v2.0.7/dmctl/dmctl --master-addr=172.16.6.1:8161 query-status test -s mysql-replica-01
{
    "result": true,
    "msg": "",
    "sources": [
        {
            "result": true,
            "msg": "",
            "sourceStatus": {
                "source": "mysql-replica-01",
                "worker": "dm-172.16.6.7-8363",
                "result": null,
                "relayStatus": null
            },
            "subTaskStatus": [
                {
                    "name": "test",
                    "stage": "Running",
                    "unit": "Load",
                    "result": null,
                    "unresolvedDDLLockID": "",
                    "load": {
                        "finishedBytes": "64011683",
                        "totalBytes": "3854328608",
                        "progress": "1.66 %",
                        "metaBinlog": "(mysql-bin.000005, 918368254)",
                        "metaBinlogGTID": "1e62060e-3c65-11ec-a30b-0242ac110002:1-5633"
                    }
                }
            ]
        }
    ]
}

Versions of the cluster

Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

(paste TiDB cluster version here)

TiCDC version (execute cdc version):

(paste TiCDC version here)

DM version (execute dmctl -V):

nightly
@GMHDBJD GMHDBJD added type/bug The issue is confirmed as a bug. area/dm Issues or PRs related to DM. labels Nov 3, 2021
@lance6716 lance6716 reopened this Dec 28, 2021
@lance6716
Copy link
Contributor

caused by

tiflow/dm/loader/loader.go

Lines 224 to 225 in 528ca40

// update finished offset after checkpoint updated
w.loader.finishedDataSize.Store(job.offset)
introduced in pingcap/dm#1778

@lance6716
Copy link
Contributor

/assign @Ehco1996

@Ehco1996
Copy link
Contributor

/assign @Ehco1996

i am sorry but i not remeber why i do this change in that PR 😅
fixed in #4093

ti-chi-bot added a commit to ti-chi-bot/tiflow that referenced this issue Jan 18, 2022
…ngcap#4323)

* fix the txn_batch_size metric inaccuracy bug when the sink target is MQ

* address comments

* add comments for exported functions

* fix the compiling problem

* workerpool: limit the rate to output deadlock warning (pingcap#3775) (pingcap#3795)

* tests(ticdc): set up the sync diff output directory correctly (pingcap#3725) (pingcap#3741)

* relay(dm): use binlog name comparison (pingcap#3710) (pingcap#3712)

* dm/load: fix concurrent call Loader.Status (pingcap#3459) (pingcap#3468)

* cdc/sorter: make unified sorter cgroup aware (pingcap#3436) (pingcap#3439)

* tz (ticdc): fix timezone error (pingcap#3887) (pingcap#3906)

* pkg,cdc: do not use log package (pingcap#3902) (pingcap#3940)

* *: rename repo from pingcap/ticdc to pingcap/tiflow (pingcap#3959)

* http_*: add log for http api and refine the err handle logic (pingcap#2997) (pingcap#3307)

* etcd_worker: batch etcd patch (pingcap#3277) (pingcap#3389)

* http_api (ticdc): check --cert-allowed-cn before add server common name (pingcap#3628) (pingcap#3882)

* kvclient(ticdc): fix kvclient takes too long time to recover (pingcap#3612) (pingcap#3663)

* owner: fix owner tick block http request (pingcap#3490) (pingcap#3530)

* dm/syncer: use downstream PK/UK to generate DML (pingcap#3168) (pingcap#3256)

* dep(dm): update go-mysql (pingcap#3914) (pingcap#3934)

* dm/syncer: multiple rows use downstream schema (pingcap#3308) (pingcap#3953)

* errorutil,sink,syncer: add errorutil to handle ignorable error (pingcap#3264) (pingcap#3995)

* dm/worker: don't exit when failed to read checkpoint in relay (pingcap#3345) (pingcap#4005)

* syncer(dm): use an early location to reset binlog and open safemode (pingcap#3860)

* ticdc/owner: Fix ddl special comment syntax error (pingcap#3845) (pingcap#3978)

* dm/scheduler: fix inconsistent of relay status (pingcap#3474) (pingcap#4009)

* owner,scheduler(cdc): fix nil pointer panic in owner scheduler (pingcap#2980) (pingcap#4007) (pingcap#4016)

* config(ticdc): Fix old value configuration check for maxwell protocol (pingcap#3747) (pingcap#3783)

* sink(ticdc): cherry pick sink bug fix to release 5.3 (pingcap#4083)

* master(dm): clean and treat invalid load task (pingcap#4004) (pingcap#4145)

* loader: fix wrong progress in query-status for loader (pingcap#4093) (pingcap#4143)

close pingcap#3252

* ticdc/processor: Fix backoff base delay misconfiguration (pingcap#3992) (pingcap#4028)

* dm: load table structure from dump files (pingcap#3295) (pingcap#4163)

* compactor: fix duplicate entry in safemode (pingcap#3432) (pingcap#3434) (pingcap#4088)

* kv(ticdc): reduce eventfeed rate limited log (pingcap#4072) (pingcap#4111)

close pingcap#4006

* metrics(ticdc): add resolved ts and add changefeed to dataflow (pingcap#4038) (pingcap#4104)

* This is an automated cherry-pick of pingcap#4192

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* retry(dm): align with tidb latest error message (pingcap#4172) (pingcap#4254)

close pingcap#4159, close pingcap#4246

* owner(ticdc): Add bootstrap and try to fix the meta information in it (pingcap#3838) (pingcap#3865)

* redolog: add a precleanup process when s3 enable (pingcap#3525) (pingcap#3878)

* ddl(dm): make skipped ddl pass `SplitDDL()` (pingcap#4176) (pingcap#4227)

close pingcap#4173

* cdc/sink: remove Initialize method from the sink interface (pingcap#3682) (pingcap#3765)

Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com>

* http_api (ticdc): fix http api 'get processor' panic. (pingcap#4117) (pingcap#4123)

close pingcap#3840

* sink (ticdc): fix a deadlock due to checkpointTs fall back in sinkNode (pingcap#4084) (pingcap#4099)

close pingcap#4055

* cdc/sink: adjust kafka initialization logic (pingcap#3192) (pingcap#4162)

* try fix conflicts.

* This is an automated cherry-pick of pingcap#4192

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* fix conflicts.

* fix conflicts.

Co-authored-by: zhaoxinyu <zhaoxinyu512@gmail.com>
Co-authored-by: amyangfei <yangfei@pingcap.com>
Co-authored-by: lance6716 <lance6716@gmail.com>
Co-authored-by: sdojjy <sdojjy@qq.com>
Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com>
Co-authored-by: 3AceShowHand <jinl1037@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
3 participants