Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owner, gcutil: always update service GC safepoint when owner finds new changefeeds (#2512) #2854

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2512

What problem does this PR solve?

Extend creating service gc safepoint ttl to 1 hr to support creating changefeeds that needs long initialization time.
Also let TiCDC always update service GC safepoint when it finds a new changefeed, see https://github.com/pingcap/ticdc/pull/2512/files#diff-0e06be9eaec63633a515c0b4eafda0d674cfa49885009c96b1389c1f1002f22cR335

Close #2470

image

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Create a changefeed that captures 60k tables.

Related changes

  • Need to cherry-pick to the release branch

Release note

Extend creating service gc safepoint ttl to 1 hr to support creating changefeeds that needs long initialization time.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 17, 2021
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR. labels Sep 17, 2021
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
@amyangfei amyangfei modified the milestones: v5.2.1, v5.2.2 Sep 18, 2021
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 47c23f9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 19, 2021
@overvenus
Copy link
Member

/merge

@overvenus
Copy link
Member

/run-kafka-tests
/run-integration-tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-5.2@a933190). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.2      #2854   +/-   ##
================================================
  Coverage               ?   56.1054%           
================================================
  Files                  ?        170           
  Lines                  ?      20752           
  Branches               ?          0           
================================================
  Hits                   ?      11643           
  Misses                 ?       7980           
  Partials               ?       1129           

@nongfushanquan nongfushanquan added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 23, 2021
@ti-chi-bot ti-chi-bot merged commit f06bbdc into pingcap:release-5.2 Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants