-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
owner, gcutil: always update service GC safepoint when owner finds new changefeeds (#2512) #2854
owner, gcutil: always update service GC safepoint when owner finds new changefeeds (#2512) #2854
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: Neil Shen <overvenus@gmail.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 47c23f9
|
/merge |
/run-kafka-tests |
Codecov Report
@@ Coverage Diff @@
## release-5.2 #2854 +/- ##
================================================
Coverage ? 56.1054%
================================================
Files ? 170
Lines ? 20752
Branches ? 0
================================================
Hits ? 11643
Misses ? 7980
Partials ? 1129 |
This is an automated cherry-pick of #2512
What problem does this PR solve?
Extend creating service gc safepoint ttl to 1 hr to support creating changefeeds that needs long initialization time.
Also let TiCDC always update service GC safepoint when it finds a new changefeed, see https://github.com/pingcap/ticdc/pull/2512/files#diff-0e06be9eaec63633a515c0b4eafda0d674cfa49885009c96b1389c1f1002f22cR335
Close #2470
Check List
Tests
Create a changefeed that captures 60k tables.
Related changes
Release note