master, config(dm): fix case-sensitive compatibility for dmctl #5307
Conversation
Signed-off-by: lance6716 <lance6716@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
needs-cherry-pick-release-5.3
ti-chi-bot
added
the
size/M
| checkAndAdjustSourceConfigFunc = checkAndAdjustSourceConfig | ||
| // the difference of below functions is checkAndAdjustSourceConfigForDMCtlFunc will not AdjustCaseSensitive. It's a | ||
| // compatibility compromise. | ||
| // When we need to change the implementation of dmctl to OpenAPI, we should notice the user about this change. |
There was a problem hiding this comment.
this upgrade case is so complex, we may add breaking change in doc and release note
see here
| @@ -308,7 +308,7 @@ func (c *SourceConfig) Adjust(ctx context.Context, db *sql.DB) (err error) { | |||
| log.L().Warn("using an absolute relay path, relay log can't work when starting multiple relay worker") | |||
| } | |||
|
|
|||
| return c.AdjustCaseSensitive(ctx2, db) | |||
| return nil | |||
There was a problem hiding this comment.
I remembered why this change was introduced, it's because when implementing openAPI , I was referring to the v2 version of the task config 😵
|
/run-dm-integration-test |
|
/run-verify |
ti-chi-bot
added
size/L
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #5307 +/- ##
================================================
+ Coverage 56.1240% 56.1245% +0.0005%
================================================
Files 522 526 +4
Lines 65325 68838 +3513
================================================
+ Hits 36663 38635 +1972
- Misses 25094 26468 +1374
- Partials 3568 3735 +167 |
|
/run-dm-integration-test |
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: a3f945b
|
ti-chi-bot
added
the
status/can-merge
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created: #5308. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created: #5309. |
|
In response to a cherrypick label: new pull request created: #5310. |
Signed-off-by: lance6716 lance6716@gmail.com
What problem does this PR solve?
Issue Number: close #5255
What is changed and how it works?
OpenAPI needs automatically decides the case-sensitive from MySQL, but dmctl should keep the compatibility. So I split the two functions.
Check List
Tests
Code changes
Side effects
Related changes
Release note