fb/latency(cdc): agent fix inconsistent state by tolerant duplicate messages. #5791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
ti-chi-bot
added
size/M
overvenus
approved these changes
Jun 8, 2022
overvenus
pushed a commit
to overvenus/ticdc
that referenced
this pull request
Jun 21, 2022
…essages. (pingcap#5791) * agent should return absent directly. * do not panic when remove table not exist. * no need to check for table status.
overvenus
pushed a commit
to overvenus/ticdc
that referenced
this pull request
Jun 21, 2022
…essages. (pingcap#5791) * agent should return absent directly. * do not panic when remove table not exist. * no need to check for table status.
overvenus
pushed a commit
to overvenus/ticdc
that referenced
this pull request
Jun 23, 2022
…essages. (pingcap#5791) * agent should return absent directly. * do not panic when remove table not exist. * no need to check for table status.
overvenus
pushed a commit
to overvenus/ticdc
that referenced
this pull request
Jun 23, 2022
…essages. (pingcap#5791) * agent should return absent directly. * do not panic when remove table not exist. * no need to check for table status.
overvenus
pushed a commit
to overvenus/ticdc
that referenced
this pull request
Jun 24, 2022
…essages. (pingcap#5791) * agent should return absent directly. * do not panic when remove table not exist. * no need to check for table status.
overvenus
pushed a commit
to overvenus/ticdc
that referenced
this pull request
Jun 24, 2022
…essages. (pingcap#5791) * agent should return absent directly. * do not panic when remove table not exist. * no need to check for table status.
overvenus
pushed a commit
to overvenus/ticdc
that referenced
this pull request
Jun 24, 2022
…essages. (pingcap#5791) * agent should return absent directly. * do not panic when remove table not exist. * no need to check for table status.
overvenus
pushed a commit
to overvenus/ticdc
that referenced
this pull request
Jun 24, 2022
…essages. (pingcap#5791) * agent should return absent directly. * do not panic when remove table not exist. * no need to check for table status.
ti-chi-bot
pushed a commit
that referenced
this pull request
Jun 24, 2022
…essages. (#5791) * agent should return absent directly. * do not panic when remove table not exist. * no need to check for table status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #4757
What is changed and how it works?
for remove table request, check if the target exist before process the request.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note