Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tp: add metrics #5823

Merged
merged 4 commits into from
Jun 10, 2022
Merged

tp: add metrics #5823

merged 4 commits into from
Jun 10, 2022

Conversation

overvenus
Copy link
Member

What problem does this PR solve?

Issue Number: ref #4757

What is changed and how it works?

Add metrics

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

image

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

None

@overvenus
tp: fill resolved ts when add a new table
621984d 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
tp: relax invarint check
f6dd88d 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
tp: add metrics
b99a24d 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus added component/scheduler TiCDC inner scheduler component. component/metrics-logging Metrics and logging component. area/ticdc Issues or PRs related to TiCDC. labels Jun 10, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 10, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 10, 2022
@overvenus
tp: record tasks in burstBalance
1a3960a 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 10, 2022
@3AceShowHand 3AceShowHand merged commit 6944518 into pingcap:fb/latency Jun 10, 2022
@overvenus overvenus mentioned this pull request Jun 13, 2022
Closed
37 tasks
3AceShowHand pushed a commit to 3AceShowHand/tiflow that referenced this pull request Jun 14, 2022
@overvenus @3AceShowHand
tp: add metrics (pingcap#5823)
f6b9874 
* tp: fill resolved ts when add a new table

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: relax invarint check

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: add metrics

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: record tasks in burstBalance

Signed-off-by: Neil Shen <overvenus@gmail.com>
overvenus added a commit to overvenus/ticdc that referenced this pull request Jun 21, 2022
@overvenus
tp: add metrics (pingcap#5823)
67d2f4f 
* tp: fill resolved ts when add a new table

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: relax invarint check

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: add metrics

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: record tasks in burstBalance

Signed-off-by: Neil Shen <overvenus@gmail.com>
overvenus added a commit to overvenus/ticdc that referenced this pull request Jun 21, 2022
@overvenus
tp: add metrics (pingcap#5823)
833874a 
* tp: fill resolved ts when add a new table

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: relax invarint check

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: add metrics

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: record tasks in burstBalance

Signed-off-by: Neil Shen <overvenus@gmail.com>
overvenus added a commit to overvenus/ticdc that referenced this pull request Jun 23, 2022
@overvenus
tp: add metrics (pingcap#5823)
62a4fce 
* tp: fill resolved ts when add a new table

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: relax invarint check

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: add metrics

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: record tasks in burstBalance

Signed-off-by: Neil Shen <overvenus@gmail.com>
overvenus added a commit to overvenus/ticdc that referenced this pull request Jun 23, 2022
@overvenus
tp: add metrics (pingcap#5823)
4b25d6d 
* tp: fill resolved ts when add a new table

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: relax invarint check

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: add metrics

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: record tasks in burstBalance

Signed-off-by: Neil Shen <overvenus@gmail.com>
overvenus added a commit to overvenus/ticdc that referenced this pull request Jun 24, 2022
@overvenus
tp: add metrics (pingcap#5823)
8d4a544 
* tp: fill resolved ts when add a new table

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: relax invarint check

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: add metrics

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: record tasks in burstBalance

Signed-off-by: Neil Shen <overvenus@gmail.com>
overvenus added a commit to overvenus/ticdc that referenced this pull request Jun 24, 2022
@overvenus
tp: add metrics (pingcap#5823)
f3819eb 
* tp: fill resolved ts when add a new table

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: relax invarint check

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: add metrics

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: record tasks in burstBalance

Signed-off-by: Neil Shen <overvenus@gmail.com>
overvenus added a commit to overvenus/ticdc that referenced this pull request Jun 24, 2022
@overvenus
tp: add metrics (pingcap#5823)
3401c41 
* tp: fill resolved ts when add a new table

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: relax invarint check

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: add metrics

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: record tasks in burstBalance

Signed-off-by: Neil Shen <overvenus@gmail.com>
overvenus added a commit to overvenus/ticdc that referenced this pull request Jun 24, 2022
@overvenus
tp: add metrics (pingcap#5823)
eb3e7ca 
* tp: fill resolved ts when add a new table

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: relax invarint check

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: add metrics

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: record tasks in burstBalance

Signed-off-by: Neil Shen <overvenus@gmail.com>
ti-chi-bot pushed a commit that referenced this pull request Jun 24, 2022
@overvenus @ti-chi-bot
tp: add metrics (#5823)
6027fd5 
* tp: fill resolved ts when add a new table

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: relax invarint check

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: add metrics

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: record tasks in burstBalance

Signed-off-by: Neil Shen <overvenus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. component/metrics-logging Metrics and logging component. component/scheduler TiCDC inner scheduler component. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@overvenus @ti-chi-bot @3AceShowHand