Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version(ticdc): adjust cdc version range to 6.3.0-alpha ~ 8.0.0-alpha #6710

Merged
merged 4 commits into from
Aug 11, 2022
Merged

version(ticdc): adjust cdc version range to 6.3.0-alpha ~ 8.0.0-alpha #6710

merged 4 commits into from
Aug 11, 2022

Conversation

3AceShowHand
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #4757

What is changed and how it works?

change cdc version from [6.3.0, 8.0.0), to [6.3.0-alpha, 8.0.0-alpha), so that 6.3.0-master in the range.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

None`

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 11, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • overvenus
  • sdojjy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 11, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 11, 2022
lonng
lonng reviewed Aug 11, 2022
View reviewed changes
pkg/version/check_test.go
require.Equal(t, 1, releaseVersion.Compare(*MinTiCDCVersion))

// build with uncommitted changes, `vx.y.z-dirty`
dirtyVersion := semver.New(removeVAndHash("v6.3.0-dirty"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which one is greater between v6.3.0-dirty and v6.3.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are equal, since v6.3.0-dirty will be changed to v6.3.0 first before comparison.

overvenus
overvenus approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 11, 2022
@3AceShowHand
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 64c0cd7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 11, 2022
@Rustin170506 Rustin170506 changed the title version(cdc): adjust cdc version range to 6.3.0-alpha ~ 8.0.0-alpha version(ticdc): adjust cdc version range to 6.3.0-alpha ~ 8.0.0-alpha Aug 11, 2022
@Rustin170506
Copy link
Member

/run-all-tests

@3AceShowHand
Copy link
Contributor Author

/run-integration-test
/run-kafka-integration-test

@3AceShowHand
Copy link
Contributor Author

/run-dm-integration-test

1 similar comment
@3AceShowHand
Copy link
Contributor Author

/run-dm-integration-test

@ti-chi-bot ti-chi-bot merged commit 1893198 into pingcap:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonng lonng lonng left review comments

@sdojjy sdojjy sdojjy approved these changes

@overvenus overvenus overvenus approved these changes

@Rustin170506 Rustin170506 Rustin170506 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@3AceShowHand @ti-chi-bot @Rustin170506 @lonng @sdojjy @overvenus