Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add docker based building infrastructure #259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

longfangsong
Copy link

Signed-off-by: longfangsong longfangsong@icloud.com

What problem does this PR solve?

Problem Summary:

Building protobuf codes requires so many dependencies and environments (and some of them are not documented), it's too troublesome.

kvproto has already have a docker based building infrastructure, maybe we can have one here too.

What is changed and how it works?

What's Changed:

Add a Dockerfile to create a docker image, which contains all the environment settings we need.

We can use this docker image to do the build work without pain.

How it Works:

See the new readme.md.

Signed-off-by: longfangsong <longfangsong@icloud.com>
@longfangsong longfangsong changed the title build: Add docker building toolchain build: Add docker building infrastructure Feb 21, 2022
@longfangsong longfangsong changed the title build: Add docker building infrastructure build: Add docker based building infrastructure Feb 21, 2022
Copy link

@Andrewmatilde Andrewmatilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CLAassistant
Copy link

CLAassistant commented Mar 13, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants