Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TiDB-binlog related code #342

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

Benjamin2037
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #341

Problem Summary:
Remove TiDB-Binlog code, because TiDB-Binlog depricated in v8.3

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

@CLAassistant
Copy link

CLAassistant commented Sep 9, 2024

CLA assistant check
All committers have signed the CLA.

fzzf678
fzzf678 previously approved these changes Sep 11, 2024
@lance6716
Copy link

Also delete the CI "Test go and binlog generation" in .github/workflows/unit-test.yml

@Benjamin2037
Copy link
Contributor Author

/hold

@Benjamin2037
Copy link
Contributor Author

/unhold

@Benjamin2037 Benjamin2037 merged commit a3fd288 into pingcap:master Sep 11, 2024
4 checks passed
@Benjamin2037 Benjamin2037 deleted the remove-pb-of-binlog branch September 11, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove binlog related pb implement
4 participants