Skip to content

Commit

Permalink
fix: avoid override mistake (#1939)
Browse files Browse the repository at this point in the history
  • Loading branch information
erights committed Apr 5, 2024
1 parent 06df1df commit 9c39e0f
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 3 deletions.
11 changes: 8 additions & 3 deletions browser.js
Original file line number Diff line number Diff line change
Expand Up @@ -263,9 +263,14 @@ function getBindingChain (logger) {

function set (self, opts, rootLogger, level) {
// override the current log functions with either `noop` or the base log function
self[level] = levelToValue(self.level, rootLogger) > levelToValue(level, rootLogger)
? noop
: rootLogger[baseLogFunctionSymbol][level]
Object.defineProperty(self, level, {
value: (levelToValue(self.level, rootLogger) > levelToValue(level, rootLogger)
? noop
: rootLogger[baseLogFunctionSymbol][level]),
writable: true,
enumerable: true,
configurable: true
})

if (!opts.transmit && self[level] === noop) {
return
Expand Down
12 changes: 12 additions & 0 deletions test/browser-early-console-freeze.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
'use strict'
Object.freeze(console)
const test = require('tape')
const pino = require('../browser')

test('silent level', ({ end, fail, pass }) => {
pino({
level: 'silent',
browser: { }
})
end()
})

0 comments on commit 9c39e0f

Please sign in to comment.