Fix deadlock when canceling processor task #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maicki
reviewed
Jun 15, 2017
There was a problem hiding this comment.
Thanks @zachwaugh for working on that - Looks good to me.
@garrettmoon Curious if in this place we should use locked_downloadTaskUUID instead of using the instance variable directly.
|
@zachwaugh Thank you so much for the investigation and fix here! @maicki my opinion is it's not necessary here since it would essentially just be a method that purely wrapped the ivar? |
garrettmoon
approved these changes
Jun 15, 2017
|
@zachwaugh Mind adding an entry to CHANGELOG.md? |
|
@garrettmoon sure thing, just updated it |
maicki
approved these changes
Jun 15, 2017
garrettmoon
pushed a commit
that referenced
this pull request
Jun 15, 2017
* Use direct ivar access to fix deadlock on accessing downloadTaskUUID * Add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use direct ivar access for
_downloadTaskUUIDsinceself.downloadTaskUUIDuses a lock as well and causes a deadlock when called here. Fixes #372