Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce gc pressure on xorBytesCTR, #2877 #298

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

aankur
Copy link
Contributor

@aankur aankur commented Oct 2, 2024

Description

Reduce GC pressure on xorBytesCTR, by using sync.pool

Reference issue

Fixes #2877 (pion/webrtc#2877)

@Sean-Der
Copy link
Member

Sean-Der commented Oct 2, 2024

Thank you @aankur!

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.70%. Comparing base (ac17807) to head (c8977fd).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
crypto.go 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
- Coverage   80.73%   80.70%   -0.04%     
==========================================
  Files          17       17              
  Lines        1163     1171       +8     
==========================================
+ Hits          939      945       +6     
- Misses        125      126       +1     
- Partials       99      100       +1     
Flag Coverage Δ
go 80.70% <80.00%> (-0.04%) ⬇️
wasm 80.27% <80.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aankur aankur force-pushed the fix/reduce-gc-pressure-xorBytesCTR branch from a194544 to 6d6aa2e Compare October 2, 2024 04:01
@aankur aankur changed the title reduce gc pressure on xorBytesCTR, #2877 Reduce gc pressure on xorBytesCTR, #2877 Oct 2, 2024
@Sean-Der Sean-Der force-pushed the fix/reduce-gc-pressure-xorBytesCTR branch from 3c1c74d to c8977fd Compare October 2, 2024 15:11
@Sean-Der Sean-Der merged commit 099a0b0 into pion:master Oct 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants