Refactor and add tests for git package #4927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shinnosuke Sawada <6warashi9@gmail.com>
Signed-off-by: Shinnosuke Sawada <6warashi9@gmail.com>
Signed-off-by: Shinnosuke Sawada <6warashi9@gmail.com>
Signed-off-by: Shinnosuke Sawada <6warashi9@gmail.com>
Warashi
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
t-kikuc
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4927 +/- ##
==========================================
+ Coverage 29.32% 29.39% +0.07%
==========================================
Files 321 322 +1
Lines 40835 40852 +17
==========================================
+ Hits 11974 12010 +36
+ Misses 27904 27882 -22
- Partials 957 960 +3 ☔ View full report in Codecov by Sentry. |
t-kikuc
approved these changes
May 29, 2024
khanhtc1202
reviewed
May 30, 2024
| @@ -206,7 +206,7 @@ func Test_setGCAutoDetach(t *testing.T) { | |||
| } | |||
|
|
|||
| getGCAutoDetach := func(ctx context.Context, repo *repo) (bool, error) { | |||
| cmd := exec.CommandContext(ctx, r.gitPath, "config", "--get", "gc.autoDetach") | |||
| cmd := exec.CommandContext(ctx, repo.gitPath, "config", "--get", "gc.autoDetach") | |||
There was a problem hiding this comment.
@Warashi Sorry for the late comment, look like the r variable in the below line (L210) has the same issue with this fixed one. It works because both refer to the outer r variable 👀 Would be great if you could open another PR to fix this.
There was a problem hiding this comment.
I opened another PR to fix this with other improvements.
#4932
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR does four things to improve git package.
getLatestRemoteHashForBranchfrom git clientWhich issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: No