Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Analytics 4 (GA4): configure CNCF site ID #4940

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jun 3, 2024

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much!!

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chalin @nate-double-u 😄

@khanhtc1202
Copy link
Member

@chalin Looks like the commit has not been signed yet. Could you sign the commit with git commit -s 🙏

@chalin
Copy link
Contributor Author

chalin commented Jun 4, 2024

Hi. Do you know why the DCO check seems to be blocked?

image

I submitted this PR via the GH web i/f, and for other DCO-based projects it'll sign my PRs for me. I can't tell whether this one is signed or not because the check seems stalled. I'm not at my main work computer now so I can't "force sign" it. I'll do that later today if we can't get the DCO check to confirm whether or not I've actually signed. Thanks ✨

@khanhtc1202
Copy link
Member

Hi @chalin, sorry for the wrong mentioning 🙏 It was an issue on the DCO bot GitHub App we used for PipeCD. Let us check and update from our end. Thanks for your quick response 😄
dcoapp/app#211

auto-merge was automatically disabled June 5, 2024 06:11

Base branch was modified

@khanhtc1202 khanhtc1202 requested a review from Warashi as a code owner June 6, 2024 01:59
@khanhtc1202
Copy link
Member

khanhtc1202 commented Jun 6, 2024

Hi @chalin, The DCO check app has been restored to work. Please check this log and fix the DCO issue following its instructions. Sorry for the inconvenient 🙏
DCO log: https://github.com/pipe-cd/pipecd/pull/4940/checks?check_run_id=25870773649

(If you don't want to workaround with git commit command, I think close and reopen the PR or re-edit from web UI as you did could help)

@khanhtc1202 khanhtc1202 reopened this Jun 10, 2024
@khanhtc1202
Copy link
Member

Reopen to trigger DCO check run 👀 But it look like it failed 🤔
ref: https://github.com/pipe-cd/pipecd/pull/4940/checks?check_run_id=25870773649
cc @chalin

@chalin
Copy link
Contributor Author

chalin commented Jun 10, 2024

@khanhtc1202 - I'll fix this today.

@chalin
Copy link
Contributor Author

chalin commented Jun 10, 2024

Fixed DCO issue. (It's annoying that this can't be fixed via the web i/f for patch PRs 🤷🏼‍♂️. Anyhow, it's done now.)

@t-kikuc t-kikuc merged commit b2dca47 into pipe-cd:master Jun 10, 2024
13 checks passed
@chalin chalin deleted the patch-1 branch June 10, 2024 22:39
@chalin
Copy link
Contributor Author

chalin commented Jun 10, 2024

I confirm that data is being processed:

image

@khanhtc1202
Copy link
Member

khanhtc1202 commented Jun 11, 2024

@chalin @nate-double-u thank you all for your support 😄

@github-actions github-actions bot mentioned this pull request Jun 12, 2024
@github-actions github-actions bot mentioned this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants