Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix installing-controlplane-on-k8s.md #4942

Merged
merged 5 commits into from
Jun 10, 2024
Merged

Conversation

jz543fm
Copy link
Contributor

@jz543fm jz543fm commented Jun 4, 2024

What this PR does / why we need it:
Updates docs how to Install Control Plane on Kubernetes for (MySQL + MINIO)

Which issue(s) this PR fixes:
Issue 4363

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@jz543fm
Copy link
Contributor Author

jz543fm commented Jun 4, 2024

I do not know why DCO check does not work, I commit with git add *; git commit -s -am "fix installing-controlplane-on-k8s.md"; git push

Signed-off-by: Juraj Žittňanský <juraj.zittnansky@firma.seznam.cz>
@t-kikuc
Copy link
Member

t-kikuc commented Jun 4, 2024

@jz543fm
Sorry, it seems the DCO checker's problem...
We'll investigate it.

@khanhtc1202
Copy link
Member

@jz543fm Thanks for the PR, I will check the DCO stage, looks like it blocks other PRs as well 🏃

@jz543fm
Copy link
Contributor Author

jz543fm commented Jun 4, 2024

Ok, I will wait for fix, yea, that's why I closed the first PR...

@jz543fm jz543fm requested a review from Warashi as a code owner June 5, 2024 07:12
jz543fm and others added 3 commits June 6, 2024 07:05
Signed-off-by: Juraj Žittňanský <juraj.zittnansky@firma.seznam.cz>
Signed-off-by: Juraj Žittňanský <juraj.zittnansky@firma.seznam.cz>
@jz543fm
Copy link
Contributor Author

jz543fm commented Jun 9, 2024

@khanhtc1202 fixed

@t-kikuc t-kikuc enabled auto-merge (squash) June 9, 2024 11:03
Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We should copy the change into v0.47.x and dev.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 🙌

@t-kikuc t-kikuc merged commit 9c7eabb into pipe-cd:master Jun 10, 2024
13 checks passed
@github-actions github-actions bot mentioned this pull request Jun 12, 2024
@github-actions github-actions bot mentioned this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants