Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup DCO workflow #4944

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Setup DCO workflow #4944

merged 3 commits into from
Jun 5, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Jun 5, 2024

What this PR does / why we need it:

This PR adds a workflow to check DCO.
I added this workflow because the app to check DCO is now down.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

because of the dcoapp's hosting side issue, add a workflow to check DCO

Signed-off-by: Shinnosuke Sawada <shin@warashi.dev>
@t-kikuc
Copy link
Member

t-kikuc commented Jun 5, 2024

Thanks!
dcoapp/app#211 (comment) is related.

After the DCO recovers, this action will be removed, right? @Warashi @khanhtc1202

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.38%. Comparing base (a949b4f) to head (2b96b79).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4944      +/-   ##
==========================================
- Coverage   29.39%   29.38%   -0.02%     
==========================================
  Files         322      322              
  Lines       40852    40852              
==========================================
- Hits        12010    12004       -6     
- Misses      27882    27888       +6     
  Partials      960      960              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Warashi
Copy link
Contributor Author

Warashi commented Jun 5, 2024

After the DCO recovers, this action will be removed, right? @Warashi @khanhtc1202

I think so.
I noticed some actions in this workflow is not allowed in this repository, so I'll push some fix.

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, I commented a nit.

@@ -0,0 +1,23 @@
name: DCO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[IMO] How about specifying this DCO is a workaround?

Suggested change
name: DCO
name: DCO-workaround

Signed-off-by: Shinnosuke Sawada <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada <shin@warashi.dev>
@Warashi Warashi requested a review from t-kikuc June 5, 2024 02:14
@Warashi
Copy link
Contributor Author

Warashi commented Jun 5, 2024

This workflow runs as this.
https://github.com/pipe-cd/pipecd/actions/runs/9377057788/job/25817994492?pr=4944

@khanhtc1202 Since I cannot modify branch protection rules, please change the required checks.

@khanhtc1202
Copy link
Member

@Warashi Updated the branch protection rules to remove DCO workflow as required step 👍

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Warashi Warashi merged commit 9fe4525 into master Jun 5, 2024
16 of 18 checks passed
@Warashi Warashi deleted the dco-workflow branch June 5, 2024 06:15
@Warashi
Copy link
Contributor Author

Warashi commented Jun 5, 2024

@khanhtc1202
I merged this PR, so please update the branch protection rules to add DCO-workaround as required.

@github-actions github-actions bot mentioned this pull request Jun 12, 2024
@github-actions github-actions bot mentioned this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants