[docs] Describe restrictions in configuring ECS serviceDef & taskDef #4962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
t-kikuc
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
Warashi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4962 +/- ##
=======================================
Coverage 29.38% 29.39%
=======================================
Files 322 322
Lines 40852 40852
=======================================
+ Hits 12006 12010 +4
+ Misses 27885 27882 -3
+ Partials 961 960 -1 ☔ View full report in Codecov by Sentry. |
Warashi
reviewed
Jun 10, 2024
Comment on lines
+514
to
+533
| ### Restrictions of Service Definition | ||
|
|
||
| There are some restrictions in configuring a service definition file. | ||
|
|
||
| - `capacityProviderStrategy` is not supported. | ||
| - `clientToken` is not supported. | ||
| - `deploymentController` is required and must be `EXTERNAL`. | ||
| - `loadBalancers` is not supported. Use `targetGroups` in [ECSDeploymentInput](#ecsdeploymentinput) instead. | ||
| - `platformFamily` is not supported. | ||
| - `propagateTags` is always set as `SERVICE`. | ||
| - `taskDefinition` is not supported. PipeCD uses the definition in `taskDefinitionFile` in [ECSDeploymentInput](#ecsdeploymentinput). | ||
|
|
||
| ### Restrictions of Task Definition | ||
|
|
||
| There are some restrictions in configuring a task definition file. | ||
|
|
||
| - `placementConstraints` is not supported. | ||
| - `proxyConfiguration` is not supported. | ||
| - `tags` is not supported. | ||
|
|
There was a problem hiding this comment.
There are notes describing some restrictions on Configuring ECS application page.
Please move these notes here and mention them on that page.
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
as title.
Which issue(s) this PR fixes:
Fixes #4961
Does this PR introduce a user-facing change?: N/A
How I listed