Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove github-actions bot from the contributors list #4993

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Jun 25, 2024

What this PR does / why we need it:

I modified the hack command to remove the following github-actions from the contributors list.

<a href="https://github.com/apps/github-actions"><img src="https://avatars.githubusercontent.com/in/15368?v=4" title="github-actions[bot]" width="80" height="80"></a>

As I mentioned in #4987 (comment).

Which issue(s) this PR fixes: N/A

Does this PR introduce a user-facing change?: N/A

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@t-kikuc t-kikuc enabled auto-merge (squash) June 25, 2024 03:49
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.06%. Comparing base (3723c8a) to head (da7c6ce).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4993   +/-   ##
=======================================
  Coverage   22.06%   22.06%           
=======================================
  Files         519      519           
  Lines       57247    57247           
=======================================
  Hits        12633    12633           
  Misses      43592    43592           
  Partials     1022     1022           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sed -i '/fossabot/d' README.md.tmp
sed -i '/github-actions[bot]/d' README.md.tmp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these symbols need to be escaped.

Suggested change
sed -i '/github-actions[bot]/d' README.md.tmp
sed -i '/github-actions\[bot\]/d' README.md.tmp

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Warashi Thanks, I fixed it here-> 4b7604f

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
…pecd into fix-gen-contributions

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
I checked the behavior on my Linux container with OrbStack, and it worked fine!

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@t-kikuc t-kikuc merged commit 207db98 into master Jun 26, 2024
18 checks passed
@t-kikuc t-kikuc deleted the fix-gen-contributions branch June 26, 2024 02:53
@github-actions github-actions bot mentioned this pull request Jul 4, 2024
hungran pushed a commit to hungran/pipecd that referenced this pull request Jul 6, 2024
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants