Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update piped-base image #5010

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Update piped-base image #5010

merged 1 commit into from
Jul 1, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Jul 1, 2024

What this PR does / why we need it:

This PR updates Dockerfiles to use the new piped-base image.

Which issue(s) this PR fixes:

Part of #4814

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada <shin@warashi.dev>
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.24%. Comparing base (e20cd0b) to head (1e66d14).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5010      +/-   ##
==========================================
- Coverage   22.26%   22.24%   -0.03%     
==========================================
  Files         519      519              
  Lines       57234    57234              
==========================================
- Hits        12745    12733      -12     
- Misses      43462    43474      +12     
  Partials     1027     1027              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙌

@Warashi Warashi merged commit 3df40b1 into master Jul 1, 2024
17 of 18 checks passed
@Warashi Warashi deleted the piped-image-jq branch July 1, 2024 02:36
@github-actions github-actions bot mentioned this pull request Jul 4, 2024
khanhtc1202 pushed a commit that referenced this pull request Jul 12, 2024
Signed-off-by: Shinnosuke Sawada <shin@warashi.dev>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants