Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use native Node.js histogram support #482

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

clydin
Copy link
Contributor

@clydin clydin commented Jan 12, 2024

The histogram related dependencies (hdr-histogram-js/hdr-histogram-percentiles-obj) have been replaced with the native support present in Node.js. This allows the package to have no required dependencies (with one optional for nice support on linux). The public API surface was kept in place to prevent breaking changes for users. This required a small amount of additional code to mainly transform the percentiles to the previous structure.

@clydin clydin marked this pull request as ready for review January 12, 2024 00:26
Copy link
Member

@metcoder95 metcoder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, now we can fully say that piscina will be dependency-less!

Can you just check lint, it seems is failing

The histogram related dependencies (`hdr-histogram-js`/`hdr-histogram-percentiles-obj`)
have been replaced with the native support present in Node.js. This allows the package
to have no required dependencies (with one optional for nice support on linux).
The public API surface was kept in place to prevent breaking changes for users. This
required a small amount of additional code to mainly transform the percentiles to the
previous structure.
@clydin
Copy link
Contributor Author

clydin commented Jan 12, 2024

Addressed the lint errors.

@metcoder95 metcoder95 merged commit aa5b140 into piscinajs:current Jan 12, 2024
10 checks passed
@clydin clydin deleted the native-histograms branch January 12, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants