chore: split structure #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metcoder95
force-pushed
the
chore/structure
branch
from
497da1e
to
d36dbc7
Compare
metcoder95
force-pushed
the
chore/structure
branch
3 times, most recently
from
bd8ec08
to
a92e79a
Compare
metcoder95
force-pushed
the
chore/structure
branch
from
05e58f4
to
963ae88
Compare
|
I'll be merging, please @RafaelGSS if you have any feedback I'll address it in a further PR 👍 |
| push (task : Task) : void { | ||
| this.tasks.push(task); | ||
| } | ||
| const { version } = JSON.parse( |
There was a problem hiding this comment.
@metcoder95 hi, this is currently breaking things for us.
Is this version extraction required? can we pass in a custom path or version in options instead?
This breaks flexibility in a number of ways, like using esbuild and bundling.
There was a problem hiding this comment.
Let me revert, this is causing too many problems. Will open a PR and publish a fix soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to try to reduce the complexity of the project with the goal of ease of understanding