-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use @napi-rs/nice to support Windows #655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This looks great, thanks for the contribution.
CI seems broken tho
@metcoder95 thanks, fixed |
Now Windows does not seems to be happy |
ec1e391
to
fdba994
Compare
Tests now passed on my Windows and Linux computer 🥇 |
fdba994
to
214ff30
Compare
Let's adjust the test to distinguish between linux and windows scenarios 👍 |
66258cb
to
c1d07d7
Compare
c1d07d7
to
049a24d
Compare
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v4 v4
# Navigate to the new working tree
cd .worktrees/backport-v4
# Create a new branch
git switch --create backport-655-to-v4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c56739465000f455fcf7abc2f83501054cab22a4
# Push it to GitHub
git push --set-upstream origin backport-655-to-v4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v4 Then, create a pull request where the |
(cherry picked from commit c567394)
@napi-rs/nice
is easier to install on CI@napi-rs/nice
supports Windows