[cloud ingress] Remove slackin.* domains from certs in a safe, staged way (stage 1). #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… way (stage 1). Signed-off-by: James Bartlett <jamesbartlett@pixielabs.ai>
aimichelle
approved these changes
Jul 11, 2023
aimichelle
pushed a commit
that referenced
this pull request
Jul 12, 2023
… way (stage 2). (#1610) Summary: Stage 2 of removing slackin, see #1609 for more details. This PR removes `slackin.*` from the main cert. This shouldn't be landed until #1609 is released. Type of change: /kind cleanup Test Plan: All 3 stages described in #1609 were tested on the testing cluster successfully. Signed-off-by: James Bartlett <jamesbartlett@pixielabs.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: In order to prevent downtime while google reprovisions certificates, we need to stage out the removal of the slackin domain from the cloud managed certs. The goal being that there's always one valid cert that doesn't need to be reprovisioned for every new release. To achieve this, we stage it out into 3 stages:
slackin.*domain, attach this cert to the ingress in addition to our original cert.slackin.*from the main cert.Type of change: /kind cleanup
Test Plan: Tested each stage on
testing. After each deploy testing still had a valid cert even if one of the two was reprovisioning.