Upgrade dev and linter containers to Ubuntu 24.04 #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddelnano
force-pushed
the
upgrade-chef-and-ubuntu-24-04
branch
2 times, most recently
from
c127a22
to
db69f14
Compare
ddelnano
added a commit
that referenced
this pull request
May 1, 2024
…`rules_python` (#1886) Summary: Ensure a hermetic python install is used for `pip_parse` and upgrade `rules_python` This is prerequisite work for migrating our docker dev image to Ubuntu 24.04 (#1885). In that PR, I've been running builds from within the containers built via packer to verify the upgrade is successful. This change is required to address the following issues: * The `pip_parse` for `ubuntu_package_deps` comes before the hermetic python definition. This results in a `ModuleNotFoundError` error without the `rules_python` upgrade (since python 3.12, shipped with 24.04, [removed disutils](https://peps.python.org/pep-0632/)). * The remaining `pip_parse` calls fail when run within a 24.04 container since it causes python to upgrade to 3.12. Note: `rules_python` 0.26.0 is the latest version we can easily upgrade to. The next release has issues with our current version of `rules_docker`. Since `rules_docker` is deprecated and we are at the latest version, upgrading beyond 0.26.0 seemed like it would be a more significant change. Relevant Issues: N/A Type of change: /kind dependencies Test Plan: CI build should pass and running builds in containers from #1885 succeed --------- Signed-off-by: Dom Delnano <ddelnano@gmail.com>
ddelnano
force-pushed
the
upgrade-chef-and-ubuntu-24-04
branch
from
b69b33c
to
a8a2c57
Compare
vihangm
reviewed
May 9, 2024
Signed-off-by: Dom Delnano <ddelnano@gmail.com>
ddelnano
force-pushed
the
upgrade-chef-and-ubuntu-24-04
branch
from
8739401
to
b71ed3c
Compare
Signed-off-by: James Bartlett <james@px.dev>
ddelnano
force-pushed
the
upgrade-chef-and-ubuntu-24-04
branch
from
e7265a9
to
ffea355
Compare
vihangm
reviewed
May 13, 2024
vihangm
approved these changes
May 13, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Upgrade dev and linter containers to Ubuntu 24.04
Relevant Issues: N/A
Type of change: /kind dependencies
Test Plan: CI should pass when using the new images
#ci:bpf-build-all-kernelsbuild (link)#ci:ignore-depsbuild (link)Changelog Message: Upgrade development environment to Ubuntu 24.04