Revert change that causes px deploy to timeout on initial deployment
#1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Service (pixie-io#1670)" This reverts commit c9813f7. Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
ddelnano
force-pushed
the
ddelnano/revert-operator-breaks-px-deploy
branch
from
46b4b12
to
ae6174a
Compare
aimichelle
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Revert change that causes
px deployto timeout on initial deploymentThis reverts #1670, which creates a circular dependency between the operator and the cloud connector service. The cloud connector service is responsible for registering a vizier and populating the
pl-cluster-secretsk8s secret with its vizier ID. The operator is responsible for creating the vizier services (including the cloud connector), so this call will never succeed on a fresh install.This bug doesn't cause pixie installs to fail completely. A
px deploycli command will time out after 10 minutes and then the vizier is deployed following that timeout expiration. While it eventually converges to a healthy vizier, this is a poor user experience. The perf tool is also experiencing this problem, but because it requirespx deployto return a successful status code it is causing it to fail completely.Relevant Issues: Reopens #1632
Type of change: /kind bug
Test Plan: Reverted this change and verified that the a
skaffold'ed operator doesn't timeout