Another attempt to remediate user namespace issues with ubuntu24 runners #2010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ommended by podman maintainers (pixie-io#2008)" This reverts commit aa1f72a. Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
…man commands Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
ddelnano
force-pushed
the
ddelnano/remediate-user-namespace-issues-with-ubuntu24-runners
branch
from
7641148
to
8049452
Compare
aimichelle
approved these changes
Sep 6, 2024
ddelnano
deleted the
ddelnano/remediate-user-namespace-issues-with-ubuntu24-runners
branch
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Sep 6, 2024
…u24 runners (pixie-io#2010)" This reverts commit 5dc122a. Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Sep 23, 2024
…ers (pixie-io#2010) Summary: Another attempt to remediate user namespace issues with ubuntu 24.04 runners This reverts the failed previous attempt and re-enables user namespaces on ubuntu 24.04. This is a well known behavior change between Ubuntu 22.04 and 24.04 (actions/runner-images#10443 (comment)). Since podman is running rootless, I think it's possible that the user namespace creation (clone syscall) is failing. Relevant Issues: pixie-io#1993 Type of change: /kind bugfix Test Plan: Run another production release build after merging this - Verified that this sysctl cli invocation is similar to our [existing example](https://github.com/pixie-io/pixie/blob/aa1f72a69f0a072d97accd721081f89cb8108fd1/.github/workflows/build_and_test.yaml#L87) --------- Signed-off-by: Dom Del Nano <ddelnano@gmail.com> GitOrigin-RevId: 5dc122a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Another attempt to remediate user namespace issues with ubuntu 24.04 runners
This reverts the failed previous attempt and re-enables user namespaces on ubuntu 24.04. This is a well known behavior change between Ubuntu 22.04 and 24.04 (actions/runner-images#10443 (comment)). Since podman is running rootless, I think it's possible that the user namespace creation (clone syscall) is failing.
Relevant Issues: #1993
Type of change: /kind bugfix
Test Plan: Run another production release build after merging this