Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ColorOverlayFilter #214

Merged
merged 11 commits into from
Jun 10, 2019
Merged

Add ColorOverlayFilter #214

merged 11 commits into from
Jun 10, 2019

Conversation

mudcube
Copy link
Contributor

@mudcube mudcube commented Jun 5, 2019

The ColorOverlayFilter replaces all colors within a source graphic with a single color, respecting the alpha channel of the source graphic. See attached graphic for visual example:

58738465-b7a96b00-83ba-11e9-802b-db00ab3cf6a6

The ColorOverlayFilter replaces all colors within a source graphic with a single color, respecting the alpha channel of the source graphic.
Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! There are few other small things that would be useful if you could hit:

  • Integrate this into tools/demo
  • Generate a screenshot (see tools/screenshots)
  • Add to the root README.md
  • Add to the bundle README.md

filters/color-overlay/LICENSE Outdated Show resolved Hide resolved
filters/color-overlay/types.d.ts Outdated Show resolved Hide resolved
filters/color-overlay/types.d.ts Outdated Show resolved Hide resolved
filters/color-overlay/types.d.ts Outdated Show resolved Hide resolved
filters/color-overlay/types.d.ts Outdated Show resolved Hide resolved
@mudcube
Copy link
Contributor Author

mudcube commented Jun 9, 2019

@bigtimebuddy Is there a way for the demo to only apply the filter to the swimming critters? I added the reference to this filter, but it appears to be applying it to the entire scene, which results in an image with a single color.

@bigtimebuddy
Copy link
Member

bigtimebuddy commented Jun 9, 2019

I think the property is fishOnly. Drop shadow and glow do this for an example.

@mudcube
Copy link
Contributor Author

mudcube commented Jun 9, 2019

It should be all working now!

BTWs, what's the best way to build the current working tree of pixi-filters while in development? Since the source files are checked out from npm, both the demo and the screenshot build utilities appear to not take into account any updates made to the code within pixi-filters without manually cutting/pasting the code you're currently working on into the built Javascript.

Screen Shot 2019-06-09 at 2 22 57 PM

@bigtimebuddy
Copy link
Member

Running npm run watch at the root-level only handles changes to the filters or bundles themselves. If you want to watch for the demo app, you should cd into tools/demo and run npm run watch. I can work on better ergonomics for this.

Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @mudcube.

@bigtimebuddy bigtimebuddy merged commit ddb1ec0 into pixijs:master Jun 10, 2019
finscn added a commit to finscn/pixi-filters that referenced this pull request Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants